Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pvc label to the pvc config #445

Conversation

birsanv
Copy link
Contributor

@birsanv birsanv commented Jan 19, 2024

https://issues.redhat.com/browse/ACM-8622

Changes:

  • add cluster.open-cluster-management.io/volsync-pvc: {{ $pvc.metadata.name }} to the configmap created by the replication source. It will be used on the restore hub , by the hub backup to wait on these pvcs to be created, after credentials backup is restored, and before restoring any other data
  • updated the replication destination templated to remove the check for a PVC being bound; with the use of a ReplicationDestination of type copyMethod: Snapshot, the PVC will not be bound until the snapshot is completed and a user up bounds to it. So the check is not relevant and doesn't mark anything wrong with the replication
  • replication destination template creating the resource, check for the existence of creds-time or creds-time-active restore. Depending on the type of restore ( sync versus all in once ) the creds-time-active restore may be producing the PV configs

Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
@birsanv
Copy link
Contributor Author

birsanv commented Jan 19, 2024

/cc @mprahl

@birsanv
Copy link
Contributor Author

birsanv commented Jan 22, 2024

@gparvin can you please help with the review process .. thank you

Copy link

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, gparvin, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a5518e9 into open-cluster-management-io:main Jan 22, 2024
3 checks passed
@birsanv birsanv deleted the vb_replication_dest_check branch January 22, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants