Use local-cluster label #498
Conversation
Basing things off of only the name being "local-cluster" may not be reliable. Refs: - https://issues.redhat.com/browse/ACM-13274 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Self-managed hubs might not always be named local-cluster. Refs: - https://issues.redhat.com/browse/ACM-13274 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @birsanv |
|
@dhaiducek: GitHub didn't allow me to request PR reviews from the following users: birsanv. Note that only open-cluster-management-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
thank you for the changes @JustinKuli ! /lgtm |
|
@birsanv: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/unhold |
openshift-merge-bot
bot
merged commit 82fa508
into
open-cluster-management-io:main
For a while now, self-managed hub ManagedCluster resources have had the
local-cluster='true'label, and we may start seeing those clusters have different names. This PR adjusts many occurrences in the collection of using the name; now they use the label.The change to the backup policy to avoid a named lookup is in a separate commit because I think it needs extra attention, it's less obvious than the other changes.