Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues for integraton-test #499

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix issues for integraton-test #499

merged 1 commit into from
Aug 28, 2024

Conversation

yiraeChristineKim
Copy link
Contributor

@yiraeChristineKim yiraeChristineKim commented Aug 28, 2024 •
edited
Loading

mprahl
mprahl previously approved these changes Aug 28, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Aug 28, 2024
@yiraeChristineKim yiraeChristineKim marked this pull request as draft August 28, 2024 13:49
@openshift-ci openshift-ci bot removed the lgtm label Aug 28, 2024
@yiraeChristineKim yiraeChristineKim changed the title Recover namespace name Fix issues for integraton-test Aug 28, 2024
@yiraeChristineKim yiraeChristineKim marked this pull request as ready for review August 28, 2024 14:03
dhaiducek
dhaiducek requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the Jira link? That one doesn't look like the right one.

stable/SC-System-and-Communications-Protection/policy-scc.yaml Outdated Show resolved Hide resolved
@dhaiducek
Copy link
Member

@yiraeChristineKim I'm assuming the name change is because the tests are using the open-cluster-management-global-set namespace?

@yiraeChristineKim
Copy link
Contributor Author

@yiraeChristineKim I'm assuming the name change is because the tests are using the open-cluster-management-global-set namespace?

yes yes how did you know that?

@dhaiducek
Copy link
Member

@yiraeChristineKim I'm assuming the name change is because the tests are using the open-cluster-management-global-set namespace?

yes yes how did you know that?

It's always the namespace that causes the issue...because it's huge 😆

dhaiducek
dhaiducek requested changes Aug 28, 2024
View reviewed changes
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jira link still looks wrong to me. It's an issue about the CSV export?

@yiraeChristineKim
Fix issues for integration-test
92a8a38 
- Accidentally removed name. Recovering name.
- Shorten policy-scc policy name
Ref: https://issues.redhat.com/browse/ACM-13584
Signed-off-by: yiraeChristineKim <yikim@redhat.com>
@yiraeChristineKim
Copy link
Contributor Author

The Jira link still looks wrong to me. It's an issue about the CSV export?

Sorry My bad I corrected. I was confused with search-colletor,

dhaiducek
dhaiducek approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openshift-ci openshift-ci bot added the lgtm label Aug 28, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhaiducek,mprahl,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a05e0ef into open-cluster-management-io:main Aug 28, 2024
3 checks passed
@magic-mirror-bot magic-mirror-bot bot mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprahl mprahl mprahl approved these changes

@dhaiducek dhaiducek dhaiducek approved these changes

@JustinKuli JustinKuli Awaiting requested review from JustinKuli

@gparvin gparvin Awaiting requested review from gparvin

Assignees

@mprahl mprahl

@dhaiducek dhaiducek

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiraeChristineKim @dhaiducek @mprahl