check completion only when time matches (https://issues.redhat.com/browse/ACM-14460) #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
|
/cc @dhaiducek |
dhaiducek
approved these changes
Oct 3, 2024
| @@ -207,24 +182,34 @@ spec: | |||
| name: check-backup-completed | |||
| spec: | |||
| object-templates-raw: | | |||
| {{hub with $configMap := (lookup "v1" "ConfigMap" "" "hdr-app-configmap") hub}} | |||
| {{hub $clusterName := (printf "%s" .ManagedClusterName) hub}} | |||
There was a problem hiding this comment.
(nit) What's the purpose of setting a variable to a variable here?
There was a problem hiding this comment.
hi @dhaiducek thank you for reviewing
I preferred to create separate variables, I found it easier for me to read the script.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: birsanv, dhaiducek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit f21b9b8
into
open-cluster-management-io:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ACM-14460
related to #502
Updated the policies to address just the
check-backup-completedtemplate, since QE considered the changes related to #502 add more complexity to the message statusChanges:
check-backup-completedtemplate, to workaround the false negative when the BackupSchedule.status.lastBackup did not match any Backup timestamp, I look for a Backup matching that BackupSchedule.status.lastBackup. If found : check the Completed status; if not found, don't report anything