-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check completion only when time matches (https://issues.redhat.com/browse/ACM-14460) #505
check completion only when time matches (https://issues.redhat.com/browse/ACM-14460) #505
Conversation
Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
/cc @dhaiducek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold if you want to use .ManagedClusterName
directly
LGTM!
@@ -207,24 +182,34 @@ spec: | |||
name: check-backup-completed | |||
spec: | |||
object-templates-raw: | | |||
{{hub with $configMap := (lookup "v1" "ConfigMap" "" "hdr-app-configmap") hub}} | |||
{{hub $clusterName := (printf "%s" .ManagedClusterName) hub}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) What's the purpose of setting a variable to a variable here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @dhaiducek thank you for reviewing
I preferred to create separate variables, I found it easier for me to read the script.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: birsanv, dhaiducek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
f21b9b8
into
open-cluster-management-io:main
https://issues.redhat.com/browse/ACM-14460
related to #502
Updated the policies to address just the
check-backup-completed
template, since QE considered the changes related to #502 add more complexity to the message statusChanges:
check-backup-completed
template, to workaround the false negative when the BackupSchedule.status.lastBackup did not match any Backup timestamp, I look for a Backup matching that BackupSchedule.status.lastBackup. If found : check the Completed status; if not found, don't report anything