Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add helm chart support #230

Merged
merged 21 commits into from
Sep 19, 2023
Merged

feat: add helm chart support #230

merged 21 commits into from
Sep 19, 2023

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Jul 5, 2023 •
edited
Loading

Closes #231

@Skarlso Skarlso force-pushed the supporting-helm-repository branch from 2e9fed8 to 152fd09 Compare July 5, 2023 12:27
@Skarlso Skarlso force-pushed the supporting-helm-repository branch from 152fd09 to 99a05ec Compare July 5, 2023 12:51
@Skarlso
Copy link
Contributor Author

Skarlso commented Jul 5, 2023

we should define which one take precedence.

There is no precedence, I think? They shouldn't be defined together. If both fields are set, we are going to error.

@Skarlso Skarlso force-pushed the supporting-helm-repository branch 2 times, most recently from daf4c63 to ea9a91b Compare September 5, 2023 10:55
@Skarlso
Copy link
Contributor Author

Skarlso commented Sep 5, 2023 •
edited
Loading

Things are working! 🎉

Missing:

  • Few adjustments
  • Unit tests
  • Proper e2e tests
  • Some code cleanup
  • Documentation

@Skarlso Skarlso force-pushed the supporting-helm-repository branch from 0586c9f to 9ef31a4 Compare September 12, 2023 11:39
@Skarlso
Copy link
Contributor Author

Skarlso commented Sep 12, 2023

Since this repo introduces a BUNCH of new versions and eventually all controllers will have to abid by them, it will be a super breaking change :)

@Skarlso
Copy link
Contributor Author

Skarlso commented Sep 12, 2023

Hmmmm..

=== RUN   TestHelmChartResource/Validate_OCM_Pipeline:_Deployment
    --- PASS: TestHelmChartResource/Validate_OCM_Pipeline:_Deployment (10.01s)
=== RUN   TestHelmChartResource/Validate_OCM_Pipeline:_Deployment/check_that_deployment_fluxdeployer-podinfo-pipeline-backend_is_ready
        --- PASS: TestHelmChartResource/Validate_OCM_Pipeline:_Deployment/check_that_deployment_fluxdeployer-podinfo-pipeline-backend_is_ready (10.01s)
PASS

Whhhy...

@Skarlso
Copy link
Contributor Author

Skarlso commented Sep 12, 2023 •
edited
Loading

Hmmmmmmm

PASS e2e

DONE 57 tests in 310.459s
➜  ocm-controller git:(supporting-helm-repository)

Not suuuure what's up here.

@Skarlso Skarlso force-pushed the supporting-helm-repository branch from 734cc72 to 0fa15a9 Compare September 12, 2023 13:27
@Skarlso Skarlso force-pushed the supporting-helm-repository branch from 6caa9f0 to 6c1aabc Compare September 13, 2023 08:15
@Skarlso Skarlso force-pushed the supporting-helm-repository branch from 5e2638a to aada614 Compare September 14, 2023 11:00
@Skarlso Skarlso marked this pull request as ready for review September 14, 2023 13:35
@Skarlso
Copy link
Contributor Author

Skarlso commented Sep 14, 2023

I'll add some documentation somewhere. :D

@Skarlso Skarlso requested a review from phoban01 September 14, 2023 13:36
@Skarlso Skarlso force-pushed the supporting-helm-repository branch from da9bcac to 7453fcb Compare September 14, 2023 14:48
@Skarlso Skarlso requested a review from souleb September 15, 2023 13:53
souleb
souleb reviewed Sep 18, 2023
View reviewed changes
README.md
@@ -133,6 +133,32 @@ Retrieves a `ComponentVersion` from an OCM repository. Handles authentication wi

Makes a resource available within the cluster as a snapshot.

#### HelmChart type Resource
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should explain the other resource types as a follow up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum, there are no other types actually that we differentiate.

Also, didn't want to start describing that here.

I'm not entirely sure what else to write here.

e2e/main_test.go Show resolved Hide resolved
main.go Show resolved Hide resolved
pkg/ocm/ocm.go Outdated Show resolved Hide resolved
@Skarlso Skarlso merged commit e92b30e into main Sep 19, 2023
3 checks passed
@Skarlso Skarlso deleted the supporting-helm-repository branch September 19, 2023 10:59
@Skarlso Skarlso mentioned this pull request Sep 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@souleb souleb souleb approved these changes

@phoban01 phoban01 Awaiting requested review from phoban01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support HelmCharts
2 participants
@Skarlso @souleb