remove bool return from handlers, use variable to control crash

cmds/ocm/commands/common/options/closureoption/option.go

@@ -16,7 +16,6 @@ import (
 	"github.com/open-component-model/ocm/pkg/contexts/ocm/transfer/transferhandler"
 	"github.com/open-component-model/ocm/pkg/contexts/ocm/transfer/transferhandler/standard"
 	"github.com/open-component-model/ocm/pkg/utils"
-	"github.com/open-component-model/ocm/pkg/utils/panics"
 )
 
 func From(o options.OptionSetProvider) *Option {
@@ -35,7 +34,6 @@ type Option struct {
 }
 
 func New(elemname string, settings ...interface{}) *Option {
-	defer panics.HandlePanic()
 	o := &Option{ElementName: elemname, AddReferencePath: options.Always()}
 	for _, s := range settings {
 		switch v := s.(type) {

pkg/utils/panics/panics.go

@@ -11,23 +11,23 @@ import (
 	"github.com/open-component-model/ocm/pkg/logging"
 )
 
-type PanicHandler func(interface{}) bool
+var ReallyCrash = true
+
+type PanicHandler func(interface{})
 
 var PanicHandlers = []PanicHandler{logHandler}
 
 func HandlePanic(additionalHandlers ...PanicHandler) {
-	reallyCrash := true
-
 	if r := recover(); r != nil {
 		for _, fn := range PanicHandlers {
-			reallyCrash = fn(r)
+			fn(r)
 		}
 
 		for _, fn := range additionalHandlers {
-			reallyCrash = fn(r)
+			fn(r)
 		}
 
-		if reallyCrash {
+		if ReallyCrash {
 			panic(r)
 		}
 	}
@@ -37,7 +37,7 @@ func RegisterPanicHandler(handler PanicHandler) {
 	PanicHandlers = append(PanicHandlers, handler)
 }
 
-func logHandler(r interface{}) bool {
+func logHandler(r interface{}) {
 	// Same as stdlib http server code. Manually allocate stack trace buffer size
 	// to prevent excessively large logs
 	const size = 64 << 10
@@ -48,6 +48,4 @@ func logHandler(r interface{}) bool {
 	} else {
 		logging.Logger().Error(fmt.Sprintf("Observed a panic: %#v (%v)\n%s", r, r, stacktrace))
 	}
-
-	return true
 }