incorporate review

pkg/common/accessio/cache.go

@@ -160,6 +160,12 @@ var (
 	_ RootedCache = (*blobCache)(nil)
 )
 
+// ACCESS_SUFFIX is the suffix of an additional blob related
+// file used to track the last access time by its modification time,
+// because Go does not support a platform independent way to access the
+// last access time attribute of a filesystem.
+const ACCESS_SUFFIX = ".acc"
+
 func NewDefaultBlobCache(fss ...vfs.FileSystem) (BlobCache, error) {
 	var err error
 	fs := DefaultedFileSystem(nil, fss...)
@@ -215,12 +221,12 @@ func (c *blobCache) Cleanup(p common.Printer, before *time.Time, dryrun bool) (c
 		return 0, 0, 0, 0, 0, 0, err
 	}
 	for _, e := range entries {
-		if strings.HasSuffix(e.Name(), ".acc") {
+		if strings.HasSuffix(e.Name(), ACCESS_SUFFIX) {
 			continue
 		}
 		base := vfs.Join(fs, path, e.Name())
 		if before != nil && !before.IsZero() {
-			fi, err := fs.Stat(base + ".acc")
+			fi, err := fs.Stat(base + ACCESS_SUFFIX)
 			if err != nil {
 				if !vfs.IsErrNotExist(err) {
 					if p != nil {
@@ -248,7 +254,7 @@ func (c *blobCache) Cleanup(p common.Printer, before *time.Time, dryrun bool) (c
 				fsize += e.Size()
 				continue
 			}
-			fs.RemoveAll(base + ".acc")
+			fs.RemoveAll(base + ACCESS_SUFFIX)
 		}
 		cnt++
 		size += e.Size()
@@ -270,9 +276,9 @@ func (c *blobCache) GetBlobData(digest digest.Digest) (int64, DataAccess, error)
 		path := common.DigestToFileName(digest)
 		fi, err := c.cache.Stat(path)
 		if err == nil {
-			vfs.WriteFile(c.cache, path+".acc", []byte{}, 0o600)
+			vfs.WriteFile(c.cache, path+ACCESS_SUFFIX, []byte{}, 0o600)
 			// now := time.Now()
-			// c.cache.Chtimes(path+".acc", now, now)
+			// c.cache.Chtimes(path+ACCESS_SUFFIX, now, now)
 			return fi.Size(), DataAccessForFile(c.cache, path), nil
 		}
 		if os.IsNotExist(err) {
@@ -341,7 +347,7 @@ func (c *blobCache) AddBlob(blob BlobAccess) (int64, digest.Digest, error) {
 		err = c.cache.Rename(tmp, target)
 	}
 	c.cache.Remove(tmp)
-	vfs.WriteFile(c.cache, target+".acc", []byte{}, 0o600)
+	vfs.WriteFile(c.cache, target+ACCESS_SUFFIX, []byte{}, 0o600)
 	return size, digest, err
 }
 

pkg/utils/time.go

@@ -12,6 +12,8 @@ import (
 	"github.com/open-component-model/ocm/pkg/generics"
 )
 
+// ParseDeltaTime parses a time diff relative to the actual
+// time and returns the resulting time.
 func ParseDeltaTime(s string, past bool) (time.Time, error) {
 	var t time.Time