Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic ADR research: implement a handling POC based on the ADR #105

Closed
Skarlso opened this issue Sep 9, 2022 · 2 comments · Fixed by #82 or #273
Closed

panic ADR research: implement a handling POC based on the ADR #105

Skarlso opened this issue Sep 9, 2022 · 2 comments · Fixed by #82 or #273
Assignees
@jmickey
Labels
kind/feature new feature, enhancement, improvement, extension

Comments

@Skarlso
Copy link
Contributor

Skarlso commented Sep 9, 2022

What would you like to be added:

Implement, or research what it takes to implement, the panic ADR located here.

Why is this needed:
@Skarlso Skarlso added the kind/feature new feature, enhancement, improvement, extension label Sep 9, 2022
@phoban01 phoban01 mentioned this issue Sep 16, 2022
Merged
@Skarlso
Copy link
Contributor Author

Skarlso commented Sep 16, 2022

@phoban01 This is the follow-up ticket to actually implement that ADR. Sorry. :) The ADR itself had no ticket. :)

@Skarlso Skarlso reopened this Sep 16, 2022
@phoban01
Copy link
Contributor

@Skarlso Thanks for clarifying, moved it to backlog again.

@In-Ko In-Ko mentioned this issue Oct 17, 2022
Closed
@jmickey jmickey self-assigned this Feb 17, 2023
@jmickey jmickey mentioned this issue Feb 21, 2023
Merged
mandelsoft added a commit that referenced this issue Mar 29, 2023
@jmickey @Skarlso @mandelsoft
#105 - Panic Handlers (#273)
d2d09d0 
* add panic package and handler code

* add panic handler to panic call sites

* remove bool return from handlers, use variable to control crash

* removed some handlers and refactored others to return an error instead

* changed Get to return an error instead removing the panic completely

* return error instead of panicing

* support for mapping panic to error return

* add error return for pem block

---------

Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Co-authored-by: Uwe Krueger <uwe.krueger@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmickey jmickey

Labels
kind/feature new feature, enhancement, improvement, extension
Projects
None yet
Milestone
No milestone
3 participants
@Skarlso @phoban01 @jmickey