Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge of PR #483 breaks integration tests #513

Closed
jensh007 opened this issue Sep 21, 2023 · 1 comment · Fixed by #516
Closed

Merge of PR #483 breaks integration tests #513

jensh007 opened this issue Sep 21, 2023 · 1 comment · Fixed by #516
Labels

Comments

@jensh007
Copy link
Contributor

Since merging the PR integration tests are failing:
See e.g. Run log

I can reproduce the error also when running the tests locally. First analysis:

  • It seems that he behavior of ocm push -f --copy-resources has changed

Input is like:

    components:
    ...
        resources:
          - name: image
            type: ociImage
            version: "1.10"
            access:
                type: ociArtifact
                imageReference: gcr.io/google_containers/echoserver:1.10
...

After pushing with the mentioned parameters the remote comp-descr in the oci registry contains in access/imageReferencea URL. Now the host name and path is different after PR-merge.
before: '<host>:<port>/inttest/google_containers/echoserver:1.10'
now: 'gcr.io/google_containers/echoserver:1.10'

@jensh007 jensh007 added the kind/bugfix Bug label Sep 21, 2023
@mandelsoft
Copy link
Contributor

The problem is caused by the special scenario you have here.
You do a re-transport into a target environment, which uses a different transport mode than the previous one.
First you do a reference transport and later on a value transport of the very same content.

Unfortunately this collides a little bit with the new detection of identical content, which now controls the transport.
This is very tricky.

I'm working on a solution to handle such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants