Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider transport modes for transport flow decisions #516

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Sep 21, 2023

What this PR does / why we need it:

To decide, which resources have to be transported the digest is not sufficient to handle re-transports
of exactly the same content with different transport modes (value vs reference).

This Pr checks, whether access methods would have to be changed according to the
the actual state in the target repository and the chosen transport mode. This then
controls the transport flow of a dedicated component version.

Additionally it should also handle the preserving of existing artifacts for overwrite transports.

There are several new tests now for those scenarios.

Which issue(s) this PR fixes:
Fixes #513

Special notes for your reviewer:

Release Notes:

Copy link
Contributor

@morri-son morri-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandelsoft, approved. Please check if the next integration test runs successfully through

@morri-son morri-son merged commit 8abf0ec into open-component-model:main Sep 22, 2023
@mandelsoft mandelsoft deleted the transfer branch September 22, 2023 14:07
robertwol pushed a commit that referenced this pull request Sep 25, 2023
* consider transport modes for transport flow decisions

* follow references even for skipped local transport

* fix overwrite mode keeping local access if required

---------

Co-authored-by: Gerald Morrison <67469729+morri-son@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge of PR #483 breaks integration tests
2 participants