Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also make generate after version bump in Release Job to correctly update README.md with component version references #990

Closed
jakobmoellerdev opened this issue Oct 21, 2024 · 0 comments
Closed

Also make generate after version bump in Release Job to correctly update README.md with component version references #990

jakobmoellerdev opened this issue Oct 21, 2024 · 0 comments
Assignees
@jakobmoellerdev
Labels
area/ipcei Important Project of Common European Interest kind/bugfix Bug

Comments

@jakobmoellerdev
Copy link
Contributor

What happened:

https://github.com/open-component-model/ocm/actions/runs/11407269902/job/31742898240?pr=987

causes issues after release due to check diff failing

What you expected to happen:

https://github.com/open-component-model/ocm/blob/main/.github/workflows/release.yaml#L286 should also contain a make generate call to refresh the readme.

How to reproduce it (as minimally and precisely as possible):

  1. Release
  2. Observe failing PR

Anything else we need to know:

Environment:
@jakobmoellerdev jakobmoellerdev self-assigned this Oct 21, 2024
@jakobmoellerdev jakobmoellerdev moved this from 🆕 ToDo to 📋 Next-UP in OCM Backlog Board Oct 21, 2024
@github-actions github-actions bot added the area/ipcei Important Project of Common European Interest label Oct 21, 2024
@jakobmoellerdev jakobmoellerdev mentioned this issue Oct 21, 2024
Merged
jakobmoellerdev added a commit that referenced this issue Oct 24, 2024
@jakobmoellerdev
chore(release): also call make generate to update files (#992)
ed93e9a 
This allows us to also generate the README.md files automatically so
that they contain correct references

<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it

#### Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
#990
@github-project-automation github-project-automation bot moved this from 🔍 Review to 🍺 Done in OCM Backlog Board Nov 28, 2024
@ocmbot ocmbot bot moved this from 🍺 Done to 🔒Closed in OCM Backlog Board Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobmoellerdev jakobmoellerdev

Labels
area/ipcei Important Project of Common European Interest kind/bugfix Bug
Projects
OCM Backlog Board
Status: 🔒Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakobmoellerdev