Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enhance the publishing to other repositories then github #1028

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Oct 30, 2024

What this PR does / why we need it

Publishing to external repositories might fail for various reasons, therefore we should be able to easily trigger the publishing to those repositories again and again without the need to rebuild a new release from scratch.

@hilmarf hilmarf added component/github-actions Changes on GitHub Actions or within `.github/` directory chore 🔨 labels Oct 30, 2024
@hilmarf hilmarf added this to the 2024-Q4 milestone Oct 30, 2024
@hilmarf hilmarf marked this pull request as ready for review October 30, 2024 14:02
@hilmarf hilmarf requested a review from a team as a code owner October 30, 2024 14:02
@hilmarf hilmarf enabled auto-merge (squash) October 30, 2024 14:02
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I generally like the idea to have this separately publishable, this doesnt really solve the issue of making aware of the failure in the jobs. As such I would like to talk about reverting all of this behavior into regular jobs that can be retriggered via workflow_dispatch. Im happy to hear your thoughts though.

Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve for now since it will be quite some time until we get to completely retouch this

@hilmarf hilmarf merged commit f2f7b76 into open-component-model:main Nov 5, 2024
15 checks passed
@hilmarf hilmarf added the kind/chore chore, maintenance, etc. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/github-actions Changes on GitHub Actions or within `.github/` directory kind/chore chore, maintenance, etc.
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

2 participants