skip digest for component constructors #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandelsoft
force-pushed
the
resources
branch
2 times, most recently
from
a8b1fd8 to
94f9c7a
Compare
mandelsoft
force-pushed
the
resources
branch
from
94f9c7a to
3fd5b47
Compare
jakobmoellerdev
approved these changes
Nov 11, 2024
frewilhelm
approved these changes
Nov 11, 2024
jakobmoellerdev
pushed a commit
that referenced
this pull request
Nov 11, 2024
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it complete #1070 Move handler-local options correctly to the comp handler and adapt the using code to reflect this change. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. -->
jakobmoellerdev
added a commit
that referenced
this pull request
Nov 19, 2024
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it This is a follow up from #1070 as @fabianburth and I decided that it would probably be best to group process related options under a specific struct to make it more explicit that they are optional and not part of the normal resource description #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Co-authored-by: Fabian Burth <fabian.burth@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds the option
--skip-digest-generationto theocm add componentscommand.It generally disables the digest generation for all added resources.
Additionally, the resource description may set
skipDigestGenerationtotrueto disable the digestgeneration for this particular resource.
Which issue(s) this PR fixes
Fixes open-component-model/ocm-project#322