-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to fully distroless ocm image #1087
feat: migrate to fully distroless ocm image #1087
Conversation
5672a4c
to
fbbbc24
Compare
What about: https://github.com/open-component-model/ocm/blob/main/Dockerfile ? Shouldn't we change that one as well? |
fbbbc24
to
7918791
Compare
In addition to this PR, longterm I want to completely get rid of the component based dockerfile and switch to a central one so that everyone can use docker build instead of 2 dockerfiles that differ in the build process. But I want to split this into a separate one, so for now, this should suffice |
7918791
to
81a537a
Compare
Please adjust |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes lgtm. However, we should discuss component/ocmcli/Makefile
and its Dockerfile
(as you already proposed).
not to be merged until @hilmarf explicitly approves due to cross dependency to piper step |
What this PR does / why we need it
Migrates to Distroless which has a few advantages over alpine:
I also remove the latest check in alpine since it only fetched a tag anyhow and we should pin by digest
Which issue(s) this PR fixes