chore: let's not store the release notes in the repository #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/github-actions
Mend Scan Summary: ❌Repository: open-component-model/ocm
|
hilmarf
commented
Nov 21, 2024
jakobmoellerdev
approved these changes
Nov 22, 2024
jakobmoellerdev
added a commit
that referenced
this pull request
Nov 22, 2024
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Makes sure that release notes are correctly drawn in and that we always have the version set correctly in our CTFs. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> This fixes up the release action in 2 important ways: 1. As part of the removal of the release notes we now no longer have a file to use for release notes to give to goreleaser. This means we have to temporarily create one 2. While discovering this I noticed that the Component Versions that are built, are actually using the `VERSION` variable while `EFFECTIVE_VERSION` is a combination of VERSION+COMMIT by default. I didnt want to change this behavior originally, so now I started to use VERSION for the Makefiles (which also means I had to export them as settable). This now leads to correct CTF versions `v0.19.0-rc.1` instead of `v0.19.0-dev` for example. As such its a follow up from #1120 and #1077
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
It's one step to "Simplify management of Release Notes" - #1097