fix: unable to close, unable to unref last: unable to cleanup component version, while unref last: closing component version #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilmarf
changed the title
hilmarf
changed the title
hilmarf
changed the title
hilmarf
changed the title
hilmarf
requested review from
Skarlso,
mandelsoft,
fabianburth and
jakobmoellerdev
Skarlso
reviewed
Jan 10, 2025
Skarlso
previously approved these changes
Jan 11, 2025
mandelsoft
previously requested changes
Jan 12, 2025
hilmarf
added
the
dev/second-opinion
which has been replaced by META_SEPARATOR to create OCI compliant tag
jakobmoellerdev
approved these changes
Jan 14, 2025
hilmarf
added a commit
to hilmarf/ocm
that referenced
this pull request
Jan 14, 2025
…nt version, while unref last: closing component version (open-component-model#1243) #### What this PR does / why we need it When calling ocm-cli with oci-tag-version like `0.0.1-20250108132333.build-af79499` e.g. ```bash ocm get cv ocm-oci-test.int.repositories.cloud.sap//docker.io/recmo/docker-hello-tiny:0.0.1-20250108132333.build-af79499 ``` It fails during the [finalize step](https://github.com/open-component-model/ocm/blob/releases/v0.19/api/utils/refmgmt/refcloser.go#L196), when [doing an update](https://github.com/open-component-model/ocm/blob/releases/v0.19/api/ocm/extensions/repositories/genericocireg/componentversion.go#L171), where [another round of version comparison](https://github.com/open-component-model/ocm/blob/releases/v0.19/api/ocm/extensions/repositories/genericocireg/componentversion.go#L99) happens. #### Which issue(s) this PR fixes Fixes: open-component-model#1235 Related: open-component-model#355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When calling ocm-cli with oci-tag-version like
0.0.1-20250108132333.build-af79499e.g.It fails during the finalize step, when doing an update, where another round of version comparison happens.
Which issue(s) this PR fixes
Fixes: #1235
Related: #355