Toifixes #304
Toifixes #304
Conversation
| @@ -8,9 +8,10 @@ OCMREPO ?= ghcr.io/$(GITHUBORG)/ocm | |||
| HELMINSTCOMP = $(PROVIDER)/toi/installers/helminstaller | |||
|
|
|||
| REPO_ROOT := $(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))/../.. | |||
| VERSION = $(shell git describe --tags --exact-match 2>/dev/null|| echo "$$(cat $(REPO_ROOT)/VERSION)") | |||
There was a problem hiding this comment.
Are you sure the exact-match can be omitted. The the closet tag will be used. This might be wrong. The closest tag can 1.0.0, but the dev version 1.1.0-dev coming from the VERSION file.
There was a problem hiding this comment.
We do not have VERSION file anymore. Therefore change.
currently we get:
git describe --tags
v0.3.0-rc.1-3-g3aa83cb8
This is inconvenient.
git describe --tags --exact-match
fatal: no tag exactly matches '3aa83cb8b456d1c6eb3bfd25d6645219bc6c1aca'
does not work.
Any better suggestion is welcome.
components/helmdemo/packagespec.yaml
Outdated
| configScheme: | ||
| type: object | ||
| additionalProperties: false | ||
| additionalProperties: true |
There was a problem hiding this comment.
Maybe you should adjust the scheme to directly reflect the possible structure to get validation errors in case of using unsupported fields or typos.
| @@ -8,7 +8,7 @@ MULTI ?= true | |||
| PLATFORMS = linux/amd64 linux/arm64 | |||
|
|
|||
| REPO_ROOT := $(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))/../.. | |||
| VERSION := $(shell git describe --tags --exact-match 2>/dev/null|| echo "$$(cat $(REPO_ROOT)/VERSION)") | |||
| * `make describe`: displays the component and it dependencies in a tree structure | ||
|
|
||
|
|
||
| # Usage |
There was a problem hiding this comment.
Maybe we shoud a ink to the cmds/hemlinstaller README. Here the config is explaines. (some docu added with the toi branch in mandelsoft). Should be merge it? (#305)
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release Notes: