improve ocm ref parsing #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensh007
approved these changes
Apr 14, 2023
robertwol
pushed a commit
that referenced
this pull request
Sep 25, 2023
* improve ocm ref parsing * improve OCIRegistry Ref Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
localhost or other potentially non DNS like host name parts in OCM ref expressions are not handled
correctly, even if the repository type prefix is given.
To solve the general ref parsing there is already a type UniformRepositorySpec, which holds various
parts of a reference and which is then mapped by heuristics to dedicated repository specs.
The problem here is that these heuristics cannot be unique if the intended type is not known.
Now we add type specific handlers, which can normalize the uniform spec according to the constraints
of the dedicated type.
Additionally, the OCIRegistry handler for mapping of URSs has been extended to handle the Info field, if host is not set,
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release Notes: