provide digest error for OCI artifacts #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertwol
pushed a commit
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Signing a resource of access type ociArtifact the digest must be determined. This fails if there is a permission problem.
The actually used Digest method (as part of the BlobAccess interface) does not provide an error return value,
therefore the signing error does not tell the reason for the failed signing.
The BlobAccess interface is very basic and used all over the code, therefore it is hard to change.
But the actual problem arises from accessing the access method. Here a better method with error return
is added to provide the fail reason, if the digest determination fails.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release Notes: