name-based registration support for down- und uploader #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianburth
previously approved these changes
May 25, 2023
fabianburth
requested changes
May 30, 2023
fabianburth
approved these changes
May 30, 2023
robertwol
pushed a commit
that referenced
this pull request
Sep 25, 2023
* download registration handler support * plugin support for downloader config * downloader CLI option * download command tests + fixes to make it run * plugin autoregistration for downloaders * plugin config option to disable auto registration * provide info for possible handlers * help topic for up- and downloaders * oci upload downloader * handler registration per config + config sets * align blob handler and downloader interface * rebase to new runtime handling + adapt oci downloader * assure static linking * incorporate review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR provides a uniform handling for uploader and downloader registrations
including a registration handler registry to support name-based registrations.
This feature is then used by the CLI to enable on-the fly registrations for
the resource download command (similar to the uploader registration)
The diretree downloader is now available, here, as well as downloaders provided
by plugins.
Additionally a OCI registry upload downloader is added.
It can be used to upload OCI artifacts provided by a component version
directly to an OCI registry using the download command.
A downloader just get control of handling the download of a dedicated resource.
It is his decision what to do. Typically, this should be the placement of the content
on the local filesystem, but basically all kinds of actions and targets are possible.
THis is now used by the oci/artifact downloader to upload the content to an OCI
registry as target.
Additionally, up- and downloader registration now support dedicated
config objects, which can be used to add standard registration per om config file.
The config config object now also supports named configuration sets, which are passive
by default, but can be activated by a central cli option. This way it is possible
to preconfigure dedicated (registration) scenarios, which can easily be activated per
option, instead of adding a list of fully qualified registration options.
Registration handlers now may provide info about available handlers, their names and usage,
This is used by the CLI to provide more help information.
Extend the standard plugin configuration to an option to enable the automatic registrations.
The are now done for downloaders and uploaders. Their descriptors have been extended
to selectively request an automatic registration. Otherwise they are just available for
explicit registrations via the hander namespaces provided by the registration handlers.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release Notes: