blueprint downloader #375
Merged
blueprint downloader #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianburth
force-pushed
the
blueprint-downloader
branch
from
761f258 to
9fd1347
Compare
fabianburth
force-pushed
the
blueprint-downloader
branch
from
0cae4cc to
2f97ef3
Compare
morri-son
approved these changes
Jun 30, 2023
robertwol
pushed a commit
that referenced
this pull request
Sep 25, 2023
* initial implementation of a blueprint downloader * add tests for download and registration * utilize printer within downloader implementation * fix linter issues * fix linter issues --------- Co-authored-by: Gerald Morrison <67469729+morri-son@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a downloader for landscaper blueprints to the library.
The standard access methods simply return the raw blob data. Therefore, if the artifact (in this case, a blueprint) is stored as an OCI Artifact, the access method will return the whole OCI Artifact bytes. Correspondingly, if the artifact is stored as a local artifact with its Component Descriptor as a compressed archive (e.g. .tar.gzip), the compressed archive bytes are returned.
Thus, to access the actual artifact (in this case, the blueprint), further processing (e.g. decompressing and unpacking) is required. This blueprint downloader capsules this functionality for blueprints.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release Notes: