enable using session with unmarshalable repository specs #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandelsoft
previously approved these changes
Sep 21, 2023
fabianburth
force-pushed
the
session
branch
from
a99743f to
c67a042
Compare
mandelsoft
approved these changes
Sep 21, 2023
robertwol
pushed a commit
that referenced
this pull request
Sep 25, 2023
* enable using session with unmarshalable repository specs * make Key function more generically usable * move into global utils package * make format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The session's
LookupRepository()method so far always calculated the respective key to cache the repository through calling json.Marshal on the RepositorySpec. This led to errors when the given RepositorySpec contained fields that cannot be Marshaled (such as file systems).This PR introduces a
Key(). Instead of calling json.Marshal, theLookupRepository()method now first checks whether the RepositorySpec implementsKey()to provide an alternative key.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release Notes: