Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/npm publish #650

Merged
merged 31 commits into from
Feb 13, 2024
Merged

Fix/npm publish #650

merged 31 commits into from
Feb 13, 2024

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Feb 12, 2024

Description

Fixes broken json serialization

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the size/s Small label Feb 12, 2024
@hilmarf hilmarf linked an issue Feb 12, 2024 that may be closed by this pull request
@hilmarf hilmarf requested a review from mandelsoft February 12, 2024 13:09
Copy link
Contributor

github-actions bot commented Feb 12, 2024

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 0
LICENSE RISK HIGH 9
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 1

Detailed Logs: mend-scan-> Generate Report
Mend UI

@hilmarf hilmarf marked this pull request as ready for review February 12, 2024 13:10
Copy link
Contributor

ocmbot bot commented Feb 12, 2024

Integration Tests for 1e39e53 run with result: Success βœ…!

@hilmarf hilmarf self-assigned this Feb 12, 2024
@mandelsoft mandelsoft merged commit 0dcb935 into main Feb 13, 2024
15 checks passed
@mandelsoft mandelsoft deleted the fix/npm_publish branch February 13, 2024 08:36
@hilmarf hilmarf linked an issue Apr 8, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPIC: Enhance OCM CLI with additional uploaders Create uploader for repository type "npm"
2 participants