Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's run only, where we have API key available #667

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Feb 20, 2024

Description

mend scans on forks are never successful
e.g. https://github.com/hilmarf/ocm/actions/runs/7945515639/job/21692267352
-apiKey $API_KEY is of course missing

So maybe we should consider NOT to trigger scan from forks?

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

github-actions bot commented Feb 20, 2024

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 0
HIGH RISK LICENSES 9
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 1

Detailed Logs: mend-scan-> Generate Report
Mend UI

Copy link
Contributor

ocmbot bot commented Feb 20, 2024

Integration Tests for 34e6d22 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented Feb 21, 2024

Integration Tests for 2ddf3fe run with result: Success ✅!

@morri-son morri-son merged commit 944ddec into main Feb 21, 2024
16 checks passed
@morri-son morri-son deleted the mend/skip_run_on_forks branch February 21, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants