cli: verify digests #681
Merged
cli: verify digests #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilmarf
requested changes
Mar 5, 2024
There was a problem hiding this comment.
LGTM, but there are some test failures:
https://github.com/open-component-model/ocm/actions/runs/8144045884/job/22257282304?pr=681
fabianburth
approved these changes
Mar 5, 2024
fabianburth
requested changes
Mar 5, 2024
fabianburth
previously approved these changes
Mar 5, 2024
hilmarf
reviewed
Mar 6, 2024
| @@ -89,7 +91,9 @@ func (o *SignatureCommand) Run() (rerr error) { | |||
| handler := comphdlr.NewTypeHandler(o.Context.OCM(), session, repo, comphdlr.OptionsFor(o)) | |||
| sopts := signing.NewOptions(sign, signing.Resolver(repo, lookup.Resolver)) | |||
| if !o.spec.sign { | |||
| sopts.VerifySignature = true | |||
| if len(sopts.SignatureNames) > 0 || sopts.Issuer != nil || sopts.Keyless { | |||
There was a problem hiding this comment.
What's the meaning of Keyless? It looks odd: "if there is no key (aka. Keyless), then verify the signature" ... I don't get it
hilmarf
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable the cli command
verify componentto verify digests without signature validationWhat type of PR is this? (check all applicable)
Related Tickets & Documents
Screenshots
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist: