Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven/access2 #731

Merged
merged 125 commits into from
May 21, 2024
Merged

Maven/access2 #731

merged 125 commits into from
May 21, 2024

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Apr 19, 2024

Description

Let's assume you have the following component-constructor.yaml:

name: acme.org/foo/bar
version: 0.0.1
provider:
  name: acme.org
resources:
  - name: java-sap-vcap-services
    type: mvnArtifact # new TYPE!
    version: 0.0.1
    access:
      type: mvn # new TYPE!
      repository: https://repo1.maven.org/maven2
      groupId: com.sap.cloud.environment.servicebinding
      artifactId: java-sap-vcap-services
      version: 0.10.4
      # (optional) classifier
      classifier: ''
      # (optional) extension
      extension: jar

Then you can now create a component version:

ocm add componentversions --create -F ./ctf component-constructor.yaml

And you can transfer it to any other Maven repository:

ocm transfer cv -V ./ctf ./target --uploader 'ocm/mvnArtifact="Url":"https://my.maven.repository.acme.org/artifactory/ocm-mvn-test"}'

You might need to configure proper credentials in your ~/.ocmconfig:

type: generic.config.ocm.software/v1
configurations:
  - type: credentials.config.ocm.software
    consumers:
      - identity:
          type: Repository.maven.apache.org
          hostname: int.repositories.cloud.sap
          path: artifactory/ocm-mvn-test
        credentials:
          - type: Credentials
            properties:
              username: 'my-user'
              password: 'top-secret'

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@hilmarf hilmarf removed the request for review from morri-son May 16, 2024 11:04
Copy link
Contributor

ocmbot bot commented May 16, 2024

Integration Tests for ccbbef5 run with result: Success ✅!

@hilmarf hilmarf dismissed stale reviews from fabianburth and mandelsoft May 16, 2024 12:59

all requested changes done

Copy link
Contributor

ocmbot bot commented May 16, 2024

Integration Tests for ccbbef5 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented May 17, 2024

Integration Tests for ccbbef5 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented May 17, 2024

Integration Tests for ccbbef5 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented May 17, 2024

Integration Tests for 9a9be0b run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented May 21, 2024

Integration Tests for 93c6bad run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented May 21, 2024

Integration Tests for 93c6bad run with result: Success ✅!

@fabianburth fabianburth merged commit 93412ff into main May 21, 2024
15 checks passed
@fabianburth fabianburth deleted the maven/access2 branch May 21, 2024 14:55
@fabianburth fabianburth mentioned this pull request May 28, 2024
24 tasks
fabianburth added a commit that referenced this pull request May 28, 2024
## Description
This Pull Request is a follow up to the [Pull
Request](#731) adding a
Maven Access Method. This Pull Request adds a corresponding input type,
a blob access and corresponding helper methods in the elements package
(and therefore makes several adjustments).
dee0 pushed a commit to dee0sap/ocm that referenced this pull request Jun 3, 2024
## Description
This Pull Request is a follow up to the [Pull
Request](open-component-model#731) adding a
Maven Access Method. This Pull Request adds a corresponding input type,
a blob access and corresponding helper methods in the elements package
(and therefore makes several adjustments).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

Add "maven" uploader
5 participants