!OCI Annotations change in Component Descriptor for Component Versions: ocm-artifact -> software.ocm.artifact and introduce software.ocm.creator
#987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
jakobmoellerdev
changed the title
ocm-artifact -> software.ocm.artifact
jakobmoellerdev
changed the title
ocm-artifact -> software.ocm.artifactocm-artifact -> software.ocm.artifact
mandelsoft
force-pushed
the
annotations
branch
3 times, most recently
from
2d38326 to
df9e942
Compare
jakobmoellerdev
requested changes
Oct 21, 2024
api/ocm/extensions/repositories/genericocireg/annotation_test.go
Outdated
Show resolved
Hide resolved
mandelsoft
force-pushed
the
annotations
branch
2 times, most recently
from
5f1fc6b to
6086f6a
Compare
jakobmoellerdev
changed the title
ocm-artifact -> software.ocm.artifactocm-artifact -> software.ocm.artifact and introduce software.ocm.creator
jakobmoellerdev
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
For OCM repositories based on OCI registries, the manifest now gets an annotation
software.ocm.componentversionwith the component version it represents.The image spec (https://github.com/opencontainers/image-spec/blob/main/annotations.md) state, that annotation names should use a reverse DNS domain prefix.
Therefore we should adapt the names of the already existing layer annotations accordingly. This PR prepends the actuals names with `software.ocm.".
The old layer annotation changes from
ocm-artifact->software.ocm.artifact.Which issue(s) this PR fixes
Fixes open-component-model/ocm-project#190