Skip to content
This repository has been archived by the owner on Feb 14, 2025. It is now read-only.

chore: remove personal information #134

Merged
merged 2 commits into from
Apr 9, 2024
Merged

chore: remove personal information #134

merged 2 commits into from
Apr 9, 2024

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Mar 25, 2024

Description

Related to open-component-model/ocm-project#43

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • πŸ“œ README.md
  • πŸ™… no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Skarlso Skarlso requested a review from morri-son March 25, 2024 13:52
Copy link

github-actions bot commented Mar 25, 2024

Mend Scan Summary: ❌

Repository: open-component-model/replication-controller

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 2
LICENSE RISK HIGH 7
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

@Skarlso Skarlso requested review from hilmarf and sk31337 April 9, 2024 06:09
@hilmarf hilmarf enabled auto-merge (squash) April 9, 2024 06:38
hilmarf
hilmarf previously requested changes Apr 9, 2024
pkg/ocm/ocm_test.go Show resolved Hide resolved
pkg/ocm/ocm_test.go Show resolved Hide resolved
@Skarlso Skarlso dismissed hilmarf’s stale review April 9, 2024 06:54

I added a clarification to the test data. Thanks for flagging it.

@hilmarf hilmarf merged commit f002c63 into main Apr 9, 2024
3 checks passed
@hilmarf hilmarf deleted the remove-personal-info branch April 9, 2024 07:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: πŸ”’Closed
Development

Successfully merging this pull request may close these issues.

2 participants