This repository has been archived by the owner on Feb 14, 2025. It is now read-only.
feat: adding service account as possible creds #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skarlso
force-pushed
the
service-account
branch
2 times, most recently
from
fb7f1f5 to
58c8057
Compare
Skarlso
force-pushed
the
service-account
branch
from
58c8057 to
dd680b8
Compare
Signed-off-by: Piaras Hoban <phoban01@gmail.com>
… successfully reconciliation Signed-off-by: Piaras Hoban <phoban01@gmail.com>
Skarlso
commented
Apr 12, 2023
pkg/ocm/ocm.go
Outdated
| if err != nil { | ||
| return false, fmt.Errorf("failed to get repository for spec: %w", err) | ||
| panic(err) |
phoban01
changed the title
Skarlso
force-pushed
the
service-account
branch
2 times, most recently
from
be639f5 to
c4ff2e8
Compare
Skarlso
force-pushed
the
service-account
branch
from
c4ff2e8 to
498f2da
Compare
Skarlso
commented
Apr 13, 2023
|
We'll test that with the end-to-end flow. It's covered now partially through unit tests. |
|
It's workiiiing! :) Previously, when we deleted the usage of the service account it was still authenticated because the context remained configured. Now it's no longer doing that. |
Skarlso
force-pushed
the
service-account
branch
from
adb47b8 to
de89424
Compare
phoban01
approved these changes
Apr 13, 2023
pkg/ocm/ocm.go
Outdated
| } | ||
| } | ||
|
|
||
| if err := c.maybeConfigureAccessCredentials(ctx, octx, obj.Spec.Source, obj.Namespace); err != nil { |
There was a problem hiding this comment.
This is kind of a weird name 😄 configureCredentials would make sense to me.
Comment on lines
8
to
14
| secretRef: | ||
| name: creds | ||
| credentials: | ||
| secretRef: | ||
| name: creds | ||
| url: ghcr.io/phoban01/ocm-podify | ||
| destination: | ||
| secretRef: | ||
| name: creds | ||
| credentials: | ||
| serviceAccountName: service-account-for-destination |
There was a problem hiding this comment.
this needs to be updated I think
pkg/ocm/ocm.go
Outdated
Comment on lines
322
to
325
| if obj.Spec.ServiceAccountName == "" { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
could this check be outside the method? then you only need to pass in the service account name and the contexts.
There was a problem hiding this comment.
I'm also using obj.Namespace,. But I can pass that in instead. Would minimize the memory burden.
| }, | ||
| }, | ||
| { | ||
| name: "component access with secret ref", |
Skarlso
force-pushed
the
service-account
branch
from
efe7f28 to
f3e030e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.