-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only show the first 25 releases in "Releases Table" #35
Conversation
@@ -341,6 +341,11 @@ <h4 class="panel-title"> | |||
</h4> | |||
</div> | |||
<div class="panel-body"> | |||
{% if releases|length > 25 %} | |||
<p> | |||
{%blocktrans%}Only showing the first 25 releases. If you want to see more, look at the spreadsheet in "Convert" above.{%endblocktrans%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bjwebb don't we normally put spaces in {% template commands %}
?
As for copy, I think:
"Showing the first 25 releases. To explore all your data in a tabular format, convert it to a spreadsheet using the "Convert" section, above".
@jpmckinney , how does that sound to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robredpath Sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bjwebb don't we normally put spaces in {% template commands %}?
Normally. Altough I copied this from further down the file. I'll update this along with the text.
c663c73
to
e5d7c33
Compare
This is what the new text looks like: Here's the change in file size of the request for some different files:
This change makes a big difference for valid data, but not so much for invalid data (which has long lists of information about each error). |
@Bjwebb Where is repeated_errors_repeated.json stored? Can we have a private repo with useful test data, if some if it can't be made public? |
@jpmckinney Currently its just on my desktop. I can't put it in a GitHub repository directly, because there's a limit on file size of 100 MB. It's a file I've created by programmatically by repeating some smaller data, so I could make a repository with a script to recreate it. |
Can we make the number 25 a configurable setting? Feel free to create a new issue if you prefer to do that in a second PR. |
Private repo with sample data exists now: https://github.com/open-contracting/sample-data-private |
No description provided.