Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only show the first 25 releases in "Releases Table" #35

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

Bjwebb
Copy link
Contributor

@Bjwebb Bjwebb commented Apr 28, 2020

No description provided.

@Bjwebb Bjwebb marked this pull request as draft April 28, 2020 15:14
@Bjwebb
Copy link
Contributor Author

Bjwebb commented Apr 28, 2020

@@ -341,6 +341,11 @@ <h4 class="panel-title">
</h4>
</div>
<div class="panel-body">
{% if releases|length > 25 %}
<p>
{%blocktrans%}Only showing the first 25 releases. If you want to see more, look at the spreadsheet in "Convert" above.{%endblocktrans%}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bjwebb don't we normally put spaces in {% template commands %}?

As for copy, I think:

"Showing the first 25 releases. To explore all your data in a tabular format, convert it to a spreadsheet using the "Convert" section, above".

@jpmckinney , how does that sound to you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robredpath Sounds good!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bjwebb don't we normally put spaces in {% template commands %}?

Normally. Altough I copied this from further down the file. I'll update this along with the text.

@Bjwebb Bjwebb force-pushed the 31-big-files branch 3 times, most recently from c663c73 to e5d7c33 Compare May 6, 2020 10:17
@Bjwebb
Copy link
Contributor Author

Bjwebb commented May 6, 2020

This is what the new text looks like:
Screenshot from 2020-05-06 10-48-39

Here's the change in file size of the request for some different files:

File Valid? File Size Response size before PR Response size after PR
releases.ocds.json Valid 366MB 156MB 3.92 MB
repeated_errors_repeated.json (not public data) Invalid 359MB 65.8 MB 27.32 MB
badfile_repeated.json (script to generate) Invalid 341MB 174.18 MB 150 MB

This change makes a big difference for valid data, but not so much for invalid data (which has long lists of information about each error).

@Bjwebb Bjwebb requested a review from kindly May 6, 2020 10:22
@Bjwebb Bjwebb marked this pull request as ready for review May 6, 2020 12:46
@jpmckinney
Copy link
Member

@Bjwebb Where is repeated_errors_repeated.json stored? Can we have a private repo with useful test data, if some if it can't be made public?

@Bjwebb
Copy link
Contributor Author

Bjwebb commented May 6, 2020

@jpmckinney Currently its just on my desktop.

I can't put it in a GitHub repository directly, because there's a limit on file size of 100 MB. It's a file I've created by programmatically by repeating some smaller data, so I could make a repository with a script to recreate it.

@jpmckinney
Copy link
Member

Can we make the number 25 a configurable setting? Feel free to create a new issue if you prefer to do that in a second PR.

@Bjwebb
Copy link
Contributor Author

Bjwebb commented Jun 4, 2020

Private repo with sample data exists now: https://github.com/open-contracting/sample-data-private

@jpmckinney jpmckinney mentioned this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants