Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document reason for freezing a publication #353

Open
jpmckinney opened this issue Apr 27, 2024 · 4 comments
Open

Document reason for freezing a publication #353

jpmckinney opened this issue Apr 27, 2024 · 4 comments
Assignees
Labels
component: admin Relating to the Django admin enhancement New feature or request

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Apr 27, 2024

Can discuss in this issue first.

We can also consider adding a note (with a date) in the admin when freezing a publication.

@jpmckinney jpmckinney added documentation Improvements or additions to documentation discussion labels Apr 27, 2024
@yolile
Copy link
Member

yolile commented Aug 5, 2024

The current criteria are:

  • The source data is broken/not available
  • The source data is not being updated anymore

@jpmckinney jpmckinney changed the title Document criteria for freezing a publication Document reason for freezing a publication Aug 6, 2024
@jpmckinney
Copy link
Member Author

jpmckinney commented Aug 6, 2024

Ok, added criteria to docs:

A publication is frozen if:

  • The spider is removed from Kingfisher Collect. The publication will never be updated.
  • The source is temporarily broken or otherwise unavailable. Unfreeze the publication when the source is fixed.

I think it might be useful to track temporary freezes via the admin, as right now we would need to compare to Collect issues to figure out why something is frozen.

@jpmckinney jpmckinney added enhancement New feature or request component: admin Relating to the Django admin and removed documentation Improvements or additions to documentation discussion labels Aug 6, 2024
@yolile
Copy link
Member

yolile commented Aug 7, 2024

Ok, added criteria to docs:

I think that we are missing one criterion, that is when the source is not broken and it is still available but is not updated with new data anymore (my second bullet)

I think it might be useful to track temporary freezes via the admin

Agree, we should add a note with a date as you suggested

@jpmckinney
Copy link
Member Author

I think that we are missing one criterion, that is when the source is not broken and it is still available but is not updated with new data anymore (my second bullet)

Aha, but in that case, don't we set retrieval frequency to NEVER? We don't need to freeze those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: admin Relating to the Django admin enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants