eForms SDK 1.3.0 upgrade

[jpmckinney]

Changed xpathAbsolute (need to update eForms example):

• BT-118-NoticeResult
• BT-156-NoticeResult
• BT-660-LotResult

Changed xpathAbsolute (no guidance yet, so no change needed):

• BT-271-Lot
• BT-271-LotsGroup
• BT-271-Procedure
• OPA-118-NoticeResult-Currency

Codelist changes (might need to update listName in eForms example):

• nuts -> nuts-lvl3
• country -> eforms-country

New fields:

• BT-1118-NoticeResult
• BT-1561-NoticeResult
• BT-195(BT-1118)-NoticeResult
• BT-195(BT-1561)-NoticeResult
• BT-196(BT-1118)-NoticeResult
• BT-196(BT-1561)-NoticeResult
• BT-197(BT-1118)-NoticeResult
• BT-197(BT-1561)-NoticeResult
• BT-198(BT-1118)-NoticeResult
• BT-198(BT-1561)-NoticeResult
• BT-1711-Tender
• BT-805-Lot
• OPA-36-Lot-Number
• OPA-36-Part-Number
• OPA-98-Lot-Number

Removed fields:

• BT-271-Part
• BT-762-notice
• BT-803(t)-notice
• OPT-090-LotsGroup BT-330, BT-1375, BT-556: Write guidance for groups of lots #71

Other changes:

• Some repeatable changed to false
• Many mandatory changed to false
• Some xpaths have [cbc:ID/text()='CrossBorderLaw'] added – I think this makes no difference to our work
  • Same sort of change to BT-65-Lot, BT-71-Part, BT-771-Lot, BT-772-Lot, OPP-030-Tender
• Renamed a bunch of ND- nodes (causing changes in parentNodeID) – no difference to our work
• Adds a regex pattern for OPP-090-Procedure – no difference to our work

[odscjen]

updated eforms example for:

• BT-118-NoticeResult
• BT-156-NoticeResult
• BT-660-LotResult

updated eforms example codelists for:

• nuts-lvl3
• eforms-country

Annoyingly the SDK guidance doesn't appear to have updated the example XML they give, e.g. for the Notice Result section containing BT-118 the example still has the old name.

[jpmckinney]

the SDK guidance doesn't appear to have updated the example XML they give

Can you report that in https://github.com/OP-TED/eForms-SDK/discussions ?

[odscjen]

Done, also it appears that BT-762 and BT-803(t) weren't suppose to be removed OP-TED/eForms-SDK#190 (reply in thread), they'll be getting added back in with 1.3.1

[jpmckinney]

Ah, thanks! We'll restore:

    eForms guidance: These values map to the same `Amendment` objects as created for BT-140. Update the corresponding `Amendment` objects and map to its `.rationale`.
    eForms example: <efac:ChangeReason><efbc:ReasonDescription languageID="ENG">Clerical corrections of ...</efbc:ReasonDescription></efac:ChangeReason>
    OCDS example: '{"tender":{"amendments":[{"rationale":"Clerical corrections of ..."}]}}'
    sdk: https://docs.ted.europa.eu/eforms/1.2.1/schema/all-in-one.html#changeReasonSection

    eForms example: <efbc:TransmissionTime>08:30:03+01:00</efbc:TransmissionTime>
    sdk: https://docs.ted.europa.eu/eforms/1.2.1/schema/all-in-one.html#dispatchDateEsender

[jpmckinney]

Ah, thanks! We'll restore:

Done now

[jpmckinney]

SDK 1.3.3 is coming soon. At that time, I'll change the URL pattern to use latest instead of the specific version: OP-TED/eForms-SDK#210

Other than that, I don't think anything is left to do in this issue, unless I missed something.