Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrapy config: use GIT revision as scrapyd version #803

Closed
wants to merge 1 commit into from

Conversation

yolile
Copy link
Member

@yolile yolile commented Sep 23, 2021

closes #802

I deployed the main branch with this config and the output was:

$ scrapyd-deploy kingfisher
Packing version v0.95-245-g6f2d66b-main
Deploying to project "kingfisher" in https://collect.kingfisher.open-contracting.org/addversion.json
Server response (200):
{"node_name": "ocp04", "status": "ok", "project": "kingfisher", "version": "v0.95-245-g6f2d66b-main", "spiders": 131}

Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@jpmckinney jpmckinney added blocked We can't do this yet and removed blocked We can't do this yet labels Sep 23, 2021
@jpmckinney
Copy link
Member

I was going through Scrapyd issues (I'm a maintainer of it and scrapyd-client now), and I saw this issue: scrapy/scrapyd#212

Can you test the reported issue, to see if we can reproduce it? If so, this PR would be blocked.

@yolile
Copy link
Member Author

yolile commented Sep 23, 2021

I'm a maintainer of it and scrapyd-client now

Cool!

Can you test the reported issue, to see if we can reproduce it?

Oh no, yes it is happening with our instance now 😨
I deleted the GIT version and now it is working again

@yolile yolile added the blocked We can't do this yet label Sep 23, 2021
@jpmckinney jpmckinney marked this pull request as draft September 23, 2021 20:19
@jpmckinney
Copy link
Member

Thanks for checking. I'll mark as draft so that I don't accidentally merge it.

@yolile
Copy link
Member Author

yolile commented Oct 26, 2021

I will close this PR instead of leaving it as a draft, as we don't really know when the mentioned issue will be resolved, and the change in the PR is small anyway.

@yolile yolile closed this Oct 26, 2021
@jpmckinney jpmckinney deleted the 802-git-version branch December 1, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked We can't do this yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use git commit sha as version sent to Scrapyd
2 participants