Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tech debt #139

Merged
3 commits merged into from
Apr 18, 2019
Merged

Fix tech debt #139

3 commits merged into from
Apr 18, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 17, 2019

@ghost ghost requested a review from kindly April 17, 2019 11:16
@ghost ghost self-assigned this Apr 17, 2019
Also Lock SQLAlchemy to 1.2 branch (1.3 branch has issues with an identifier being too long)
@ghost ghost force-pushed the fix-tech-debt branch from 3e6d68e to 9715cd5 Compare April 17, 2019 11:40
jsonschema==3.0.1
lxml==4.3.2
Mako==1.0.7
jsonschema==2.6.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why going back to an earlier version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing I've done.

There was a problem with the new release and we locked it in a lib https://github.com/OpenDataServices/lib-cove/blob/master/setup.py#L14

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit :)

@ghost ghost merged commit ac38e83 into master Apr 18, 2019
@ghost ghost deleted the fix-tech-debt branch April 18, 2019 07:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants