Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

279 transform no date #282

Merged
2 commits merged into from
Apr 22, 2020
Merged

279 transform no date #282

2 commits merged into from
Apr 22, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2020 •
edited by ghost
Loading

@ghost ghost self-assigned this Apr 21, 2020
@ghost ghost requested a review from jpmckinney April 21, 2020 13:23
@ghost
Copy link
Author

ghost commented Apr 21, 2020

Compile Release Transform: date missing

jpmckinney
jpmckinney reviewed Apr 21, 2020
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer extracting a common method rather than having duplicate code, but otherwise looks good.

@ghost ghost merged commit e071772 into master Apr 22, 2020
@ghost ghost deleted the 279-transform-no-date branch April 22, 2020 07:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmckinney @jarofgreen