Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: Store details of all errors when checking #305

Merged
1 commit merged into from
Jul 30, 2020
Merged

errors: Store details of all errors when checking #305

1 commit merged into from
Jul 30, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 30, 2020

@ghost ghost self-assigned this Jul 30, 2020
@ghost
Copy link
Author

ghost commented Jul 30, 2020

@jpmckinney Before I do final checks, does this basically look good?

@ghost
Copy link
Author

ghost commented Jul 30, 2020

@ghost ghost requested review from jpmckinney and mrshll1001 July 30, 2020 15:05
jpmckinney
jpmckinney previously approved these changes Jul 30, 2020
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a comment on code order.

ocdskingfisherprocess/checks.py Outdated Show resolved Hide resolved
@ghost ghost force-pushed the 301-errors branch from b287811 to af251ea Compare July 30, 2020 15:14
@ghost ghost merged commit 5263149 into master Jul 30, 2020
@ghost ghost deleted the 301-errors branch July 30, 2020 15:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants