Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report extended fields as additional fields in versionedRelease #61

Open
duncandewhurst opened this issue Sep 5, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@duncandewhurst
Copy link

Data which includes both versioned releases and extensions results in the data review tool flagging additional fields in the versioned releases.

From @kindly: it isn't possible for publishers to include versioned-release patches in their extensions because

if you applied multiple extensions that have versioned-release patches the composite output would not be correct in some cases. The only way to get correct output would be to merge the release schemas first and then apply the versioning so it would only work if you only had a single extension.

you would not patch the versioned release schema you would run https://github.com/open-contracting/standard/blob/4aec59865bc6401b017ab0b68a9536405879216e/standard/schema/utils/make_versioned_release_schema.py on the rhe patched release schema however that is not done by cove and potentially could be done.

cc @yolile

@jpmckinney
Copy link
Member

In the very short term, we can also not report additional fields on versioned releases.

@duncandewhurst
Copy link
Author

@robredpath robredpath transferred this issue from OpenDataServices/cove Oct 14, 2020
@robredpath robredpath transferred this issue from another repository Oct 14, 2020
@jpmckinney jpmckinney changed the title OCDS: Add support for extended versioned release data Add support for extended versioned release data Oct 14, 2020
@jpmckinney jpmckinney transferred this issue from open-contracting/cove-ocds Oct 14, 2020
@jpmckinney jpmckinney added checks extensions Relating to patching schema and codelists with extensions bug Something isn't working and removed checks labels Oct 14, 2020
@jpmckinney jpmckinney added wontfix and removed extensions Relating to patching schema and codelists with extensions labels Aug 18, 2021
@jpmckinney
Copy link
Member

Nevermind - the DRT doesn't report OCDS fields as additional (like in #84), but it will report extended fields as additional.

@jpmckinney jpmckinney reopened this Aug 25, 2021
@jpmckinney jpmckinney changed the title Add support for extended versioned release data Don't report extended fields as additional fields in versionedRelease Aug 25, 2021
@jpmckinney jpmckinney removed the wontfix label Jul 7, 2023
@jpmckinney
Copy link
Member

As mentioned in issue description, can be easily fixed by moving code that converts release schema to versioned schema from standard repo to ocdsextensionregistry, and then calling it in the SchemaOCDS.registry method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants