Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags all fields in records/compiledRelease as additional #84

Closed
jpmckinney opened this issue Oct 15, 2020 · 4 comments
Closed

Flags all fields in records/compiledRelease as additional #84

jpmckinney opened this issue Oct 15, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@jpmckinney
Copy link
Member

inally reported by @duncandewhurst at OpenDataServices/cove#1232

Tested with the record from the sample data repo:

image
@jpmckinney jpmckinney added bug Something isn't working additional fields upstream Requires a change in a dependency labels Oct 15, 2020
@jpmckinney jpmckinney changed the title CoVE flags all fields in records/compiledRelease as additional Flags all fields in records/compiledRelease as additional Oct 15, 2020
@duncandewhurst duncandewhurst mentioned this issue Jun 13, 2021
Closed
@jpmckinney
Copy link
Member Author

Like #61 and #68, the easiest option might just be to not report additional fields on compiled releases.

@jpmckinney jpmckinney added wontfix and removed additional fields upstream Requires a change in a dependency labels Aug 18, 2021
@duncandewhurst
Copy link

Many publishers only publish compiled releases and once open-contracting/standard#1092 is done it will be possible for publishers to publish a record package that only contains a compiled release, so I don't think we should not report additional fields on compiled releases.

@jpmckinney
Copy link
Member Author

Might have been fixed? http://standard.open-contracting.org/review/?source_url=https://raw.githubusercontent.com/open-contracting/sample-data/main/fictional-example/1.1/record/ocds-213czf-000-00001.json

@duncandewhurst
Copy link

Seems like it!

@jpmckinney jpmckinney mentioned this issue Aug 25, 2021
Open
@jpmckinney jpmckinney removed the wontfix label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpmckinney @duncandewhurst