Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements: Remove/Deprecate 'item' from relatesTo #191

Closed
jpmckinney opened this issue Sep 7, 2022 · 4 comments
Closed

Requirements: Remove/Deprecate 'item' from relatesTo #191

jpmckinney opened this issue Sep 7, 2022 · 4 comments
Labels
Codelist Involves editing a codelist Core Relates to a recommended extension Schema Involves editing the schema

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Sep 7, 2022

relatedItem implies relatesTo = 'item'. Similarly, relatedLots would imply relatesTo = 'lot' (though this code doesn't exist).

relatesTo should be reserved for 'tenderer' and 'bid' #110.

If relatedItem or relatedLots is set and relatesTo is also set, that's an incoherence data quality issue.

Requiring publishers to set relatesTo when relatedItem or relatedLots is set is unnecessary and creates an opportunity for inconsistency.

As part of this issue, we can also greatly simplify the description of relatedItem:

Where relatesTo = "item" this field must be populated with the id of the item in this tender section which the criterion relates to. Where relatesTo <> "item" this field should be omitted.

The description of relatedLots is much simpler:

The identifiers of the lots to which this criterion applies.

@jpmckinney jpmckinney added Schema Involves editing the schema Codelist Involves editing a codelist Core Relates to a recommended extension labels Sep 7, 2022
@jpmckinney jpmckinney changed the title Requirements: Remove 'item' from relatesTo Requirements: Remove/Deprecate 'item' from relatesTo Sep 7, 2022
@jpmckinney
Copy link
Member Author

jpmckinney commented Sep 7, 2022

I've now closed #110, so we now actually have the option to eliminate relatesTo entirely and instead add a boolean like relatesToTenderer (consistent with OCDS) or relatesToBidder (consistent with bid extension) or relatesToSubmitter (to "future proof" for OCDS 2.0 open-contracting/standard#906). That said, it might be best not to start introducing the new term, to avoid having 3 terms at the same time.

@yolile
Copy link
Member

yolile commented Sep 8, 2022

Note that the responseSource codelist also uses the code "tenderer", so if we want to be consistent with that field code, we should keep tenderer, I guess. (or change that code too)

@yolile
Copy link
Member

yolile commented Sep 8, 2022

As part of this, we could update the extension documentation that currently says

"The extension is designed to allow procuring entities or buyers to express criteria, relating to either items being procured or bidders themselves, as structured data."

, without mentioning lots.

@jpmckinney
Copy link
Member Author

Only moldova uses relatesTo (similar to #190)

I've changed it to relatesToTenderer (matching OCDS).

I've mentioned lots consistent (#191 (comment)), simplified the description of relatedItem (#191 (comment)), and in general applied the style guide.

open-contracting-extensions/ocds_requirements_extension@54b202f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codelist Involves editing a codelist Core Relates to a recommended extension Schema Involves editing the schema
Projects
None yet
Development

No branches or pull requests

2 participants