-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a compiledRelease schema #330
Comments
It's also worth noting that whilst the merging rules guidance states that the We should fix this as when we update the docs as part of the upgrade |
@kindly Your current code drops |
Just discussed with @kindly why dropping |
The issues that @kindly and @duncandewhurst reported haven't been fixed. |
Starting to document differences between release-schema.json and proposed compiled-release-schema.json:
|
Basic question: why do compiled releases currently have |
Tags are not cumulative. The semantics of That said, |
Hi @jpmckinney , |
@ErinClark Until this issue is resolved, it makes sense to add an additional field as you suggest. |
This would be useful for implementations that use the EU profile because it would be possible to check, using only the compiled release, if both a tender and award release had been published. For the UK, which has issues with linking tenders and awards, currently, you need to check individual releases. |
Based on #1160 (comment), +1 to accumulating tags in compiled releases. |
It's been a few years since the initial list of differences was made in #330 (comment), the following is the updated version based on the outcome of previously mentioned issues and further discussion in this and related threads.
|
@jpmckinney I've manually created a file
Is this schema what you had in mind? If it is then I can move onto making it automatable by manage.py as part of the pre-commit step |
As mentioned in #284 a compiledRelease in an OCDS record has the same schema as a standard OCDS release.
However, some of the fields, most notably the release ID and date, make no sense once compiled and they are also mandatory. This means it is not possible to make a compiled release that makes sense and validates.
The best approach would be to make a new sightly modified version of the OCDS release to take this into account. Naming possibly merged-release-scema.json
The text was updated successfully, but these errors were encountered: