Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate packages on record packages #920

Closed
jpmckinney opened this issue Sep 8, 2019 · 1 comment
Closed

Deprecate packages on record packages #920

jpmckinney opened this issue Sep 8, 2019 · 1 comment
Assignees
@yolile
Labels
Focus - Packages Relating to release packages and record packages Schema: Fields Relating to adding or deprecating fields in the JSON Schema
Milestone
1.2.0

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Sep 8, 2019 •
edited
Loading

Background

Only Chile, Paraguay and Zambia use packages in record packages, using this query in Redash:

SELECT DISTINCT(data->'publisher'->>'name') FROM package_data
WHERE data->'packages' IS NOT NULL;

Discussion

It's not clear what real (not imagined) use cases this field serves.

Proposal

Deprecate packages on record packages.
@jpmckinney jpmckinney added Focus - Packages Relating to release packages and record packages Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.) labels Sep 8, 2019
@jpmckinney jpmckinney added this to the 1.2.0 milestone Sep 8, 2019
@jpmckinney jpmckinney added Schema: Fields Relating to adding or deprecating fields in the JSON Schema and removed Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.) labels Jul 17, 2020
@jpmckinney jpmckinney mentioned this issue Feb 9, 2021
Closed
@aguilerapy
Copy link

aguilerapy commented Apr 19, 2021 •
edited
Loading

Update: all these scrapers download record packages with the packages field:

chile_compra_bulk
chile_compra_records
mexico_nuevo_leon_records
moldova
nigeria_budeshi_records
paraguay_dncp_records
portugal_records
portugal
zambia

@yolile yolile self-assigned this Jul 15, 2021
@yolile yolile mentioned this issue Jul 15, 2021
Merged
@jpmckinney jpmckinney mentioned this issue Aug 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yolile yolile

Labels
Focus - Packages Relating to release packages and record packages Schema: Fields Relating to adding or deprecating fields in the JSON Schema
Projects
OCDS 1.2
Status: Done
Milestone
1.2.0
Development

No branches or pull requests
3 participants
@jpmckinney @yolile @aguilerapy