Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record-package-schema: deprecate packages #1339

Merged
merged 6 commits into from
Jul 19, 2021
Merged

record-package-schema: deprecate packages #1339

merged 6 commits into from
Jul 19, 2021

Conversation

yolile
Copy link
Member

@yolile yolile commented Jul 15, 2021

closes #920

@yolile
record-package-schema: deprecated packages
a569352 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile
changelog: Add deprecate record package packages field
a99b3db 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile yolile changed the title record-package-schema: deprecated packages record-package-schema: deprecate packages Jul 16, 2021
@yolile yolile requested a review from jpmckinney July 16, 2021 14:09
jpmckinney
jpmckinney reviewed Jul 16, 2021
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also update records_reference.md to not mention packages (including in the jsoninclude directive). We also need to remove it from any example files.

docs/history/changelog.md Outdated Show resolved Hide resolved
schema/record-package-schema.json Outdated Show resolved Hide resolved
@jpmckinney jpmckinney added the unresolved-suggestions To filter pull requests with unresolved suggestions label Jul 16, 2021
yolile and others added 4 commits July 16, 2021 16:02
@yolile @jpmckinney
record-package-schema: clarify packages deprecation description
f2c3756 
Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com>
@yolile
Merge branch '1.2-dev' of github.com:open-contracting/standard into 9…
c562b56 
…20-deprecate-packages
@yolile
examples: remove packages from record packages
423c177 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile
records_referece: remove record package 'packages' reference
8e41cff 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile yolile requested a review from jpmckinney July 16, 2021 21:58
@jpmckinney jpmckinney removed the unresolved-suggestions To filter pull requests with unresolved suggestions label Jul 16, 2021
@jpmckinney jpmckinney merged commit 90c6d4f into 1.2-dev Jul 19, 2021
@jpmckinney jpmckinney deleted the 920-deprecate-packages branch July 19, 2021 18:30
@jpmckinney jpmckinney added this to the 1.2.0 milestone Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OCDS 1.2
Status: Done
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yolile @jpmckinney