Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate contractSchedule and edit contractAnnexe #1186

Merged
merged 5 commits into from
Feb 17, 2021
Merged

Deprecate contractSchedule and edit contractAnnexe #1186

merged 5 commits into from
Feb 17, 2021

Conversation

ColinMaudry
Copy link
Member

Close #870

@ColinMaudry
Copy link
Member Author

ColinMaudry commented Jan 28, 2021 •
edited
Loading

Error in the tests:

schema/codelists/documentType.csv: Additional properties are not allowed ('Deprecation note' was unexpected) (items/additionalProperties)

@jpmckinney Do we adapt the tests or remove the extra deprecation columns in documentType.csv ?

@ColinMaudry ColinMaudry added this to the 1.2.0 milestone Feb 1, 2021
@ColinMaudry ColinMaudry linked an issue Feb 3, 2021 that may be closed by this pull request
documentType: Deprecate contractSchedule in favor of contractAnnexe #870
Closed
jpmckinney and others added 3 commits February 12, 2021 18:55
@jpmckinney
Merge branch '1.2-dev' into 870_contractAnnexe
0d53068
@ColinMaudry @jpmckinney
Typo
6ac0060 
Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com>
@ColinMaudry
Merge branch '1.2-dev' into 870_contractAnnexe
6bfeee2
@jpmckinney jpmckinney merged commit 4960d9c into 1.2-dev Feb 17, 2021
@jpmckinney jpmckinney deleted the 870_contractAnnexe branch February 17, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney Awaiting requested review from jpmckinney

Assignees
No one assigned
Labels
None yet
Projects
OCDS 1.2
Status: Done
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

documentType: Deprecate contractSchedule in favor of contractAnnexe
2 participants
@ColinMaudry @jpmckinney