Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record-package-schema: remove releases in record requirement #1393

Merged
merged 4 commits into from
Sep 1, 2021
Merged

record-package-schema: remove releases in record requirement #1393

merged 4 commits into from
Sep 1, 2021

Conversation

yolile
Copy link
Member

@yolile yolile commented Aug 24, 2021

closes #1092

@yolile
record-package-schema: remove releases in record requirement
188a54d 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile
changelog: add records.releases entry
de3c6a4 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile yolile requested a review from jpmckinney August 24, 2021 19:09
jpmckinney
jpmckinney reviewed Aug 25, 2021
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no longer clear that a compiledRelease "should" be included when releases are included, but we've learned that compiled releases are rarely included, or are incorrectly calculated, so I think just the original releases is fine.

docs/history/changelog.md Outdated Show resolved Hide resolved
docs/schema/records_reference.md Outdated Show resolved Hide resolved
docs/schema/records_reference.md Outdated Show resolved Hide resolved
docs/schema/records_reference.md Outdated Show resolved Hide resolved
docs/schema/records_reference.md Outdated Show resolved Hide resolved
yolile and others added 2 commits August 31, 2021 16:19
@yolile @jpmckinney
Apply suggestions from code review
8afa65e 
Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com>
@yolile
recods_reference: remove record.releases admonition
62fbc07 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile yolile requested a review from jpmckinney August 31, 2021 20:22
@jpmckinney jpmckinney merged commit 46be658 into 1.2-dev Sep 1, 2021
@jpmckinney jpmckinney deleted the 1092-releases-optional-record branch September 1, 2021 23:40
@jpmckinney jpmckinney added this to the 1.2.0 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OCDS 1.2
Status: Done
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Make releases optional on Record definition
2 participants
@yolile @jpmckinney