Skip to content

Commit d5e16f5

Browse files
authored
Merge pull request #585 from open-craft/0x29a/bb7841/fix-permissions
fix: eSHE Instructor should be able to see forum members and enrollments [BB-7841]
2 parents b68314b + 2be436d commit d5e16f5

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

lms/djangoapps/instructor/permissions.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
RESCORE_EXAMS = 'instructor.rescore_exams'
3030
VIEW_REGISTRATION = 'instructor.view_registration'
3131
VIEW_DASHBOARD = 'instructor.dashboard'
32+
VIEW_ENROLLMENTS = 'instructor.view_enrollments'
33+
VIEW_FORUM_MEMBERS = 'instructor.view_forum_members'
3234

3335

3436
perms[ALLOW_STUDENT_TO_BYPASS_ENTRANCE_EXAM] = HasAccessRule('staff')
@@ -66,3 +68,5 @@
6668
'instructor',
6769
'data_researcher'
6870
) | HasAccessRule('staff') | HasAccessRule('instructor')
71+
perms[VIEW_ENROLLMENTS] = HasAccessRule('staff')
72+
perms[VIEW_FORUM_MEMBERS] = HasAccessRule('staff')

lms/djangoapps/instructor/views/api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1659,7 +1659,7 @@ def get_anon_ids(request, course_id):
16591659
@require_POST
16601660
@ensure_csrf_cookie
16611661
@cache_control(no_cache=True, no_store=True, must_revalidate=True)
1662-
@require_course_permission(permissions.CAN_ENROLL)
1662+
@require_course_permission(permissions.VIEW_ENROLLMENTS)
16631663
@require_post_params(
16641664
unique_student_identifier="email or username of student for whom to get enrollment status"
16651665
)
@@ -2609,7 +2609,7 @@ def problem_grade_report(request, course_id):
26092609
@require_POST
26102610
@ensure_csrf_cookie
26112611
@cache_control(no_cache=True, no_store=True, must_revalidate=True)
2612-
@require_course_permission(permissions.CAN_ENROLL)
2612+
@require_course_permission(permissions.VIEW_FORUM_MEMBERS)
26132613
@require_post_params('rolename')
26142614
def list_forum_members(request, course_id):
26152615
"""

0 commit comments

Comments
 (0)