fix: eSHE Instructor should be able to see forum members and enrollments [BB-7841]#585
Merged
0x29a merged 1 commit intoopencraft-release/palm.1from Sep 18, 2023
Merged
Conversation
0x29a
force-pushed
the
0x29a/bb7841/fix-permissions
branch
from
d27b3f4 to
2be436d
Compare
viadanna
approved these changes
Sep 16, 2023
Member
viadanna
left a comment
viadanna
left a comment
There was a problem hiding this comment.
👍
- I tested this
- I read through the code
| @ensure_csrf_cookie | ||
| @cache_control(no_cache=True, no_store=True, must_revalidate=True) | ||
| @require_course_permission(permissions.CAN_ENROLL) | ||
| @require_course_permission(permissions.VIEW_ENROLLMENTS) |
Member
There was a problem hiding this comment.
This makes much more sense than having it require the CAN_ENROLL 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consider this diff. We've modified
CAN_ENROLLpermission in a way that eSHE Instructors don't have it, but eSHE Instructor + Staff have.However, the same permission is used to control two other endpoints that shouldn't be forbidden to eSHE Instructor. One of them,
get_student_enrollment_status, is used for this instructor view:So this PR fixes these two endpoints for eSHE Instructors by introducing two new permissions, specific to these endpoints, with the same access level as before.
Testing instructions
0x29a/bb7841/fix-permissionsbranch from thegit@github.com:open-craft/edx-platform.gitrepo.True.eshe_instructor@example.com.eshe_instructor@example.comtheeSHE Instructorcourse team role (that can be done in the Instructor Dashboard).eshe_instructor@example.comcan view enrollment status ofstaff@example.com.