Fix studio for users with derived roles and some other related changes [BB-7834]#33275
Conversation
|
Thanks for the pull request, @0x29a! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
a04ffae to
7600032
Compare
7600032 to
5b34e08
Compare
Agrendalath
left a comment
There was a problem hiding this comment.
@0x29a, one request - please add a comment to the context manager to explain why it's here and what it can do in the plugins.
👍
- I tested this: checked the access role inheritance behaves correctly (except for the issues fixed in #33491)
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
5b34e08 to
9e56a18
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
There are three commits serving different purposes:
staffis the base, for example) can't see their our courses in Studio, whilestaffitself can. See this PR for more details.Testing instructions
This needs mainly proofreading and regression testing:
Course Staffrole check that you see your own course in Studio and that no views from the Instructor Dashboard are throwing errors.You should get this output: