feat: Add "Recently Modified" library section (TEMP) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusuf-musleh
changed the title
yusuf-musleh
force-pushed
the
yusuf-musleh/lib-v2-home-recently-modified
branch
from
6e2645c
to
2ab3e43
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jill/FAL-3758-sort-components #52 +/- ##
==============================================================
Coverage 92.68% 92.68%
==============================================================
Files 693 693
Lines 12339 12339
Branches 2699 2661 -38
==============================================================
Hits 11436 11436
Misses 872 872
Partials 31 31 ☔ View full report in Codecov by Sentry. |
yusuf-musleh
force-pushed
the
yusuf-musleh/lib-v2-home-recently-modified
branch
from
7e5bf28
to
d15231d
Compare
The "View All" action appears on sections that pass in a view all action and contain content that exceeds the defined preview limit, which defaults to 4.
yusuf-musleh
force-pushed
the
yusuf-musleh/lib-v2-home-recently-modified
branch
from
d15231d
to
a16c5c2
Compare
…-home-recently-modified
pomegranited
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
👍 Works and looks great @yusuf-musleh !
One nit, and there's 2 failing tests, but this is good to go once they're fixed.
- I tested this using my tutor dev stack and the PR test instructions
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation
- User-facing strings are extracted for translation
…' into yusuf-musleh/lib-v2-home-recently-modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See openedx#1151 description for testing instructions.