Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Correct case of Ansible setting for Celery worker timeout. #101

Merged
merged 1 commit into from
Jun 5, 2016

Conversation

smarnach
Copy link
Contributor

@smarnach smarnach commented Jun 3, 2016

The setting was uppercased in edx/configuration#2993 after #65 was merged, and never corrected here.

@itsjeyd
Copy link
Member

itsjeyd commented Jun 3, 2016

@smarnach Code LGTM. We already have a ticket for investigating the browser tests that failed in the latest build for this PR (OC-1651). They should go away when you restart the build. I haven't seen the error from the integration test before, but it also looks like an intermittent issue and doesn't seem to be related to the changes in this PR at all.

@omarkhan
Copy link
Contributor

omarkhan commented Jun 3, 2016

@smarnach I have cherry-picked this on top of my new relic branch on stage. I am deploying a new appserver with it, let's see if it works.

@omarkhan
Copy link
Contributor

omarkhan commented Jun 4, 2016

@smarnach it failed before it got to the edxapp role. Trying again...

@omarkhan
Copy link
Contributor

omarkhan commented Jun 4, 2016

@smarnach it worked! 👍

@smarnach
Copy link
Contributor Author

smarnach commented Jun 5, 2016

@omarkhan Thanks, I will merge and deploy to production now.

Is the failure you got in the first attempt something I should look into as well?

@smarnach smarnach force-pushed the smarnach/celery-setting-case branch from abe0178 to fff0bf4 Compare June 5, 2016 19:08
@smarnach smarnach merged commit c24d0be into master Jun 5, 2016
@smarnach
Copy link
Contributor Author

smarnach commented Jun 5, 2016

This is deployed in production now.

@smarnach smarnach deleted the smarnach/celery-setting-case branch August 22, 2017 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants