This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
BB-2240: Custom page editor #556
Merged
giovannicimolin
merged 13 commits into
new-console
from
giovanni/bb-2240-static-page-editor
Apr 14, 2020
Merged
BB-2240: Custom page editor #556
giovannicimolin
merged 13 commits into
new-console
from
giovanni/bb-2240-static-page-editor
Apr 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannicimolin
force-pushed
the
new-console
branch
from
April 2, 2020 18:41
1583656
to
cc777ff
Compare
Agrendalath
reviewed
Apr 5, 2020
frontend/src/console/components/CustomizationSideMenu/CustomizationSideMenu.tsx
Outdated
Show resolved
Hide resolved
giovannicimolin
force-pushed
the
giovanni/bb-2240-static-page-editor
branch
2 times, most recently
from
April 9, 2020 18:25
ab2b9b0
to
d69ebd0
Compare
Agrendalath
reviewed
Apr 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! I just saw some extra changes after the rebase.
Also answering your comment here, as GitHub for some reason doesn't display the text field under that.
We'll need to
eject
the project to include TinyMCE into the bundle, otherwise we'll get this pesky warning:
Does it mean that we would need to update everything for this package manually instead of using npm for this?
If so, wouldn't it be better to simply create an account and provide apiKey
there? I see that it's free.
giovannicimolin
force-pushed
the
new-console
branch
from
April 10, 2020 12:58
f79639a
to
f391954
Compare
giovannicimolin
force-pushed
the
giovanni/bb-2240-static-page-editor
branch
from
April 10, 2020 18:20
d69ebd0
to
0fb98b9
Compare
Agrendalath
reviewed
Apr 13, 2020
Agrendalath
reviewed
Apr 13, 2020
Agrendalath
approved these changes
Apr 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: tested that the editor works correctly, preview links are displayed and the API key is passed to the editor
- I read through the code
-
I checked for accessibility issues -
Includes documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Custom Page editor functionality in the new Ocim UX.
Testing Instructions:
Some edge cases for testing:
Reviewer: