Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

BB-2240: Custom page editor #556

Merged
merged 13 commits into from
Apr 14, 2020

Conversation

giovannicimolin
Copy link
Contributor

@giovannicimolin giovannicimolin commented Mar 30, 2020

This PR adds the Custom Page editor functionality in the new Ocim UX.

Testing Instructions:

  1. Check out this branch.
  2. Rebuild API client.
  3. Run Ocim and new frontend.
  4. Go to the custom pages and test around.

Some edge cases for testing:

  • Change the page content, them click on a link for another page.
  • Go to some page that has some text (http://localhost:3000/console/custom-pages/honor), do a browser refresh and then try to save the content without changing.
  • Do the same as above, but change the content.
  • Try erasing values.

Reviewer:

@giovannicimolin giovannicimolin force-pushed the giovanni/bb-2240-static-page-editor branch 2 times, most recently from ab2b9b0 to d69ebd0 Compare April 9, 2020 18:25
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I just saw some extra changes after the rebase.

Also answering your comment here, as GitHub for some reason doesn't display the text field under that.

We'll need to eject the project to include TinyMCE into the bundle, otherwise we'll get this pesky warning:

Does it mean that we would need to update everything for this package manually instead of using npm for this?
If so, wouldn't it be better to simply create an account and provide apiKey there? I see that it's free.

@giovannicimolin giovannicimolin force-pushed the giovanni/bb-2240-static-page-editor branch from d69ebd0 to 0fb98b9 Compare April 10, 2020 18:20
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: tested that the editor works correctly, preview links are displayed and the API key is passed to the editor
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@giovannicimolin giovannicimolin merged commit 6df9c2e into new-console Apr 14, 2020
@giovannicimolin giovannicimolin deleted the giovanni/bb-2240-static-page-editor branch April 14, 2020 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants